chore(NODE-4153): make type fixes for ts 4.7 #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
chore/fix-ts-4.7-errors
branch
from
05bd89f
to
e1b4d8a
Compare
nbbeeken
added
the
Primary Review
baileympearson
previously requested changes
Apr 1, 2022
nbbeeken
changed the title
nbbeeken
added
Team Review
durran
previously approved these changes
Apr 4, 2022
|
I like the breakout of the evg tasks now. Nice work. |
dariakp
requested changes
Apr 4, 2022
dariakp
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Typescript will now be able to narrow the types of symbol properties! So a lot of nullish checks came up.
Typescript now has more strictness about constrained generics, we need to make sure the whole chain of generics we pipe through is constrained, basically
extends Documenteverywhere.The CI will fail, 4.6 still can't narrow symbol types so I want to check with the team before I go and write the "pull out to a normal variable" code everywhere.
What is the motivation for this change?
Types in our script made with java ☕ .
Also covers: NODE-4123, NODE-4117
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>