-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-4125): change stream resumability #3289
Commits on Jun 15, 2022
-
test: add resumabilty tests for change streams
- adds resumability tests for the iterator based API (tryNext, hasNext and next) - adds resumability tests for the event emitter-based API - adds tests demonstrating that change streams do not resume on unresumable errors for iterator and event emitter based apis - adds tests for resumability iterator mode on 3.6 servers - adds resume options tests to resumability tests
Configuration menu - View commit details
-
Copy full SHA for 2dceb56 - Browse repository at this point
Copy the full SHA 2dceb56View commit details -
fix: use server selection in change stream resume process
This commit removes a custom function we had to wait until the topology was reconnected in favor of performing server selection. This is described here: https://github.com/mongodb/specifications/blob/master/source/change-streams/change-streams.rst#resume-process
Configuration menu - View commit details
-
Copy full SHA for 94a4853 - Browse repository at this point
Copy the full SHA 94a4853View commit details -
Configuration menu - View commit details
-
Copy full SHA for 881dcf2 - Browse repository at this point
Copy the full SHA 881dcf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0d82b - Browse repository at this point
Copy the full SHA 1a0d82bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45a56d2 - Browse repository at this point
Copy the full SHA 45a56d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7d2481 - Browse repository at this point
Copy the full SHA b7d2481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44635ba - Browse repository at this point
Copy the full SHA 44635baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ee61da - Browse repository at this point
Copy the full SHA 6ee61daView commit details -
Configuration menu - View commit details
-
Copy full SHA for f65cc73 - Browse repository at this point
Copy the full SHA f65cc73View commit details -
test: fix tryNext tests on sharded clusters
tryNext is not blocking and on sharded clusters we don't have control of when the actual change event will be ready on the change stream pipeline. This introduces a race condition, where sometimes we receive the change event and sometimes we don't when we call tryNext, depending on the timing of the sharded cluster. Since we really only care about the resumability, it's enough for this test to throw if tryNext ever throws and assert on the number of aggregate events.
Configuration menu - View commit details
-
Copy full SHA for 28e1b77 - Browse repository at this point
Copy the full SHA 28e1b77View commit details
Commits on Jun 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ab155d3 - Browse repository at this point
Copy the full SHA ab155d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5647d0b - Browse repository at this point
Copy the full SHA 5647d0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 031043a - Browse repository at this point
Copy the full SHA 031043aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b85dc73 - Browse repository at this point
Copy the full SHA b85dc73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68a184c - Browse repository at this point
Copy the full SHA 68a184cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3239fe1 - Browse repository at this point
Copy the full SHA 3239fe1View commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2fb5b7c - Browse repository at this point
Copy the full SHA 2fb5b7cView commit details -
- removes MongoClient.connect() call from new change stream tests - awaits a promise in iterateUntilDocumentOrError in the unified runner - removes an unused method in the change stream class
Configuration menu - View commit details
-
Copy full SHA for 315343e - Browse repository at this point
Copy the full SHA 315343eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0d0641 - Browse repository at this point
Copy the full SHA d0d0641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51a2907 - Browse repository at this point
Copy the full SHA 51a2907View commit details -
Configuration menu - View commit details
-
Copy full SHA for e20fe96 - Browse repository at this point
Copy the full SHA e20fe96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56dbbef - Browse repository at this point
Copy the full SHA 56dbbefView commit details -
chore: address comments in tests
- use to.be.a('number') in assertion - remove bracket style type assertion in favor of as
Configuration menu - View commit details
-
Copy full SHA for 8414b36 - Browse repository at this point
Copy the full SHA 8414b36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14f3fc2 - Browse repository at this point
Copy the full SHA 14f3fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50980b8 - Browse repository at this point
Copy the full SHA 50980b8View commit details -
Revert "fix: promisify server selection and iterator mode error handl…
…ing" This reverts commit 50980b8.
Configuration menu - View commit details
-
Copy full SHA for 6eb5537 - Browse repository at this point
Copy the full SHA 6eb5537View commit details -
Configuration menu - View commit details
-
Copy full SHA for 537cadf - Browse repository at this point
Copy the full SHA 537cadfView commit details
Commits on Jun 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8f99a98 - Browse repository at this point
Copy the full SHA 8f99a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa3851f - Browse repository at this point
Copy the full SHA fa3851fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e18998 - Browse repository at this point
Copy the full SHA 5e18998View commit details -
Configuration menu - View commit details
-
Copy full SHA for f848edc - Browse repository at this point
Copy the full SHA f848edcView commit details