-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-4534): unified SDAM test runner implementation #3373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! just some small comments but really appreciate how you've done sleepOrError style assertions
9b7ea19
to
4add27a
Compare
2d1432c
to
7702e63
Compare
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.spec.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test failure is the op count latency test that Bailey is taking care of |
Description
NODE-4534 / NODE-4325
What is changing?
Converting SDAM tests to unified format
createEntities
operation from unified schema 1.9thread
entities (runOnThread
,waitForThread
), TopologyDescription entities (recordTopologyDescription
,waitForPrimaryChange
,assertTopologyType
), testRunner event assertion operations (waitForEvent
,assertEventCount
), expected SDAM events, and thewait
operationMost interesting changes:
waitForEvent
implementationUnifiedThread
implementationafterEach
hookIs there new documentation needed for these changes?
No
What is the motivation for this change?
Spec compliance and more reliable tests
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>