Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4648): pull prepare shell out to script and fix reporter error handling #3418

Merged
merged 6 commits into from Sep 16, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Sep 15, 2022

Description

What is changing?

Yoinks prepare-shell out of our yml to make it easily runnable when using spawn hosts.

Our prepare script is currently embedded in our evergreen yml. Pulling it out makes running it locally and on spawn hosts much easier.

Additionally, while attempting pulling out this script it was discovered one of our tasks is failing a lot of tests but reporting success (NODE-4642). It turns out errors thrown from mocha reporters are squashed (visually) but still exit the process, but with success. It's a small change to add error handling to our reporter.

While we're adding error handling to the reporter we should remove stdout/err capturing. We don't use it, and it doesn't correctly work on evergreen, and it make xunit.xml huge.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the chore/pull-out-scripts-from-yml branch from 397e734 to c92c0e2 Compare September 15, 2022 23:59
@nbbeeken nbbeeken changed the title chore: pull prepare shell out to script to make spawn hosts easier chore(NODE-4642): pull prepare shell out to script to make spawn hosts easier Sep 16, 2022
@nbbeeken nbbeeken force-pushed the chore/pull-out-scripts-from-yml branch from 1232985 to 41dc220 Compare September 16, 2022 14:50
@nbbeeken nbbeeken changed the title chore(NODE-4642): pull prepare shell out to script to make spawn hosts easier chore(NODE-4648): pull prepare shell out to script to make spawn hosts easier Sep 16, 2022
@nbbeeken nbbeeken changed the title chore(NODE-4648): pull prepare shell out to script to make spawn hosts easier chore(NODE-4642): pull prepare shell out to script and fix reporter error handling Sep 16, 2022
@nbbeeken nbbeeken changed the title chore(NODE-4642): pull prepare shell out to script and fix reporter error handling test(NODE-4648): pull prepare shell out to script and fix reporter error handling Sep 16, 2022
@nbbeeken nbbeeken marked this pull request as ready for review September 16, 2022 17:15
@nbbeeken
Copy link
Contributor Author

this patch runs the entire waterfall to double check these changes work correctly on all platforms / setups:
https://spruce.mongodb.com/version/6324af0b32f417656e62b0cf/tasks

@nbbeeken
Copy link
Contributor Author

We're passing everything, the mongosh tests don't use our env setup

@dariakp dariakp added the Team Review Needs review from team label Sep 16, 2022
@dariakp dariakp merged commit 23537e6 into main Sep 16, 2022
@dariakp dariakp deleted the chore/pull-out-scripts-from-yml branch September 16, 2022 19:30
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
2 participants