Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5052): prevent cursor and changestream close logic from running more than once #3562

Merged
merged 30 commits into from
Feb 14, 2023
Merged

fix(NODE-5052): prevent cursor and changestream close logic from running more than once #3562

merged 30 commits into from
Feb 14, 2023

Commits on Feb 9, 2023

  1. fix(NODE-5052): prevent cursor and changestream close logic from runn… 

    …ing more than once
    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    cbebd10 View commit details
    Browse the repository at this point in the history

  2. fix: keep cleaning up session, check for unhandled errors

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    fc3ec7b View commit details
    Browse the repository at this point in the history

  3. move flag setting to after clean up

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3f02916 View commit details
    Browse the repository at this point in the history

  4. prevent mocha from ending early

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0a3bd27 View commit details
    Browse the repository at this point in the history

  5. use uncaughtExceptionMonitor

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c9db9ef View commit details
    Browse the repository at this point in the history

  6. do _something_ for unknown origin

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c24d62d View commit details
    Browse the repository at this point in the history

  7. reset arrays in after hook

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    465c058 View commit details
    Browse the repository at this point in the history

  8. removeAllListeners should be called whenever cursor closes

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    b2238f6 View commit details
    Browse the repository at this point in the history

  9. fix up legacy tests

    @nbbeeken
    nbbeeken committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4404f73 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. test cleanup 

    Co-authored-by: Durran Jordan <durran@gmail.com>
    @nbbeeken @durran
    nbbeeken and durran committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3ae17cf View commit details
    Browse the repository at this point in the history

  2. fix lint

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    aecb077 View commit details
    Browse the repository at this point in the history

  3. rollup cleanup into helpers

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    28d6ee5 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    53c1314 View commit details
    Browse the repository at this point in the history

  5. reset abstract_cursor

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6387545 View commit details
    Browse the repository at this point in the history

  6. gate on killed/closed

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    796ada5 View commit details
    Browse the repository at this point in the history

  7. gate on killed/closed round 2

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    05acf5d View commit details
    Browse the repository at this point in the history

  8. do not try to use a session that hasEnded

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    adaa40e View commit details
    Browse the repository at this point in the history

  9. cleanup test

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    eb34100 View commit details
    Browse the repository at this point in the history

  10. unknown array

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3a52ff6 View commit details
    Browse the repository at this point in the history

  11. clean up find_cursor tests

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c3c7cdb View commit details
    Browse the repository at this point in the history

  12. drop in crud_api tests

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2ac087c View commit details
    Browse the repository at this point in the history

  13. do not set kClosed early

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f1f8fd3 View commit details
    Browse the repository at this point in the history

  14. pass iterable to .race

    @nbbeeken
    nbbeeken committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    430e8aa View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. fix if stmt

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    16e582f View commit details
    Browse the repository at this point in the history

  2. remove gating

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8cbe891 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into NODE-5052-close-change-stream

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c12b8bb View commit details
    Browse the repository at this point in the history

  4. test: update title

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    feefb02 View commit details
    Browse the repository at this point in the history

  5. fix: test name org

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    08037f8 View commit details
    Browse the repository at this point in the history

  6. fix: test title

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4babaee View commit details
    Browse the repository at this point in the history

  7. improve readability

    @nbbeeken
    nbbeeken committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d1fc282 View commit details
    Browse the repository at this point in the history