fix(NODE 4518)!: Bug Fix - Unclear Error Message AuthSource isn't set to $external. #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to '$external" error, and new test for the error.
dariakp
changed the title
dariakp
added
tracked-in-jira
|
Hey @shreykumar18 - thanks for bringing our attention to this bug again. We decided to go with a slightly different approach, implemented here. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Instead of a "[object Object] can only have authSource set to '$external'", where obviously "[object Object]" error message, when a connection string is provided, the object is now clarified.
Is there new documentation needed for these changes?
No new documentation needed.
What is the motivation for this change?
It was a bug, that provided an unclear error message. The expected behaviour was to specify the object of the connection string when the authSource isn't set to $external.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript