Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-5237): fix flaky deadlock tests and modernize deadlock test suite #3679

Merged
merged 10 commits into from May 26, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 22, 2023

Description

What is changing?

The flaky deadlock tests are fixed. The root cause appears to be a typo in the original test, where the encryption key was inserted without { w: majority }.

There are a lot of cleanups in this PR too, since I was touching the files. The cleanups include:

  • conversion of the deadlock tests to Typescript
  • symbol properties have been removed from the capturing client
  • the deadlock tests have been factored out into their own top level test suite
  • the deadlock tests now use async/await
  • enables the deadlock tests when auth is enabled

The commits are can be reviewed one-at-a-time to easily diff the changes, although the commits are not perfect. Some changes introduced in a commit might be removed in a later commit (test name improvements for debugging and .only for example).

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-5237-flakey-deadlock-tests branch 2 times, most recently from 08a1a7e to fac9095 Compare May 23, 2023 03:51
@baileympearson baileympearson force-pushed the NODE-5237-flakey-deadlock-tests branch from 79138fe to a295a3e Compare May 23, 2023 14:57
@baileympearson baileympearson changed the title fix deadlock test errors test(NODE-5237): fix flaky deadlock tests and modernize deadlock test suite May 23, 2023
@baileympearson baileympearson marked this pull request as ready for review May 23, 2023 16:13
@W-A-James W-A-James self-assigned this May 25, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 25, 2023
@W-A-James W-A-James added Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 26, 2023
@dariakp dariakp removed the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 26, 2023
@W-A-James W-A-James merged commit 8bfa945 into main May 26, 2023
15 of 24 checks passed
@W-A-James W-A-James deleted the NODE-5237-flakey-deadlock-tests branch May 26, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
4 participants