New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-5237): fix flaky deadlock tests and modernize deadlock test suite #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5237-flakey-deadlock-tests
branch
2 times, most recently
from
May 23, 2023 03:51
08a1a7e
to
fac9095
Compare
baileympearson
force-pushed
the
NODE-5237-flakey-deadlock-tests
branch
from
May 23, 2023 14:57
79138fe
to
a295a3e
Compare
baileympearson
changed the title
fix deadlock test errors
test(NODE-5237): fix flaky deadlock tests and modernize deadlock test suite
May 23, 2023
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
May 25, 2023
W-A-James
reviewed
May 25, 2023
test/integration/client-side-encryption/client_side_encryption.prose.deadlock.ts
Outdated
Show resolved
Hide resolved
W-A-James
approved these changes
May 26, 2023
W-A-James
added
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
May 26, 2023
nbbeeken
approved these changes
May 26, 2023
dariakp
removed
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The flaky deadlock tests are fixed. The root cause appears to be a typo in the original test, where the encryption key was inserted without
{ w: majority }
.There are a lot of cleanups in this PR too, since I was touching the files. The cleanups include:
The commits are can be reviewed one-at-a-time to easily diff the changes, although the commits are not perfect. Some changes introduced in a commit might be removed in a later commit (test name improvements for debugging and .only for example).
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript