Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-5352): refactor AbstractOperation to use async #3729

Merged
merged 23 commits into from
Jun 29, 2023
Merged

refactor(NODE-5352): refactor AbstractOperation to use async #3729

merged 23 commits into from
Jun 29, 2023

Conversation

malikj2000
Copy link
Contributor

Description

What is changing?

created callback
subclass of operation
and changed execute

Is there new documentation needed for these changes?

no

What is the motivation for this change?

first step in asyncifying the operations layer

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

baileympearson
baileympearson requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

src/operations/execute_operation.ts Show resolved Hide resolved
src/operations/operation.ts Outdated Show resolved Hide resolved
src/operations/operation.ts Show resolved Hide resolved
@W-A-James W-A-James self-requested a review June 16, 2023 18:18
@W-A-James W-A-James self-assigned this Jun 16, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 16, 2023
W-A-James
W-A-James requested changes Jun 16, 2023
View reviewed changes
src/operations/operation.ts Outdated Show resolved Hide resolved
src/operations/execute_operation.ts Outdated Show resolved Hide resolved
src/operations/operation.ts Outdated Show resolved Hide resolved
test/unit/cmap/connection.test.ts Outdated Show resolved Hide resolved
test/unit/sdam/server.test.ts Outdated Show resolved Hide resolved
W-A-James
W-A-James requested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malikj2000 There are test failures to address

W-A-James
W-A-James requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments below, there are also some failing unit tests for operations that subclass AbstractCallbackOperation and eslint errors to address.

test/unit/cmap/connection.test.ts Outdated Show resolved Hide resolved
test/unit/sdam/server.test.ts Outdated Show resolved Hide resolved
W-A-James
W-A-James requested changes Jun 28, 2023
View reviewed changes
test/unit/operations/find.test.ts Outdated Show resolved Hide resolved
W-A-James
W-A-James previously approved these changes Jun 28, 2023
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 28, 2023
baileympearson
baileympearson requested changes Jun 28, 2023
View reviewed changes
test/unit/operations/find.test.ts Outdated Show resolved Hide resolved
baileympearson
baileympearson approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on CI after the rebase before merging but otherwise LGTM

@W-A-James W-A-James merged commit a329748 into main Jun 29, 2023
23 of 27 checks passed
@W-A-James W-A-James deleted the NODE-5352 branch June 29, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@W-A-James W-A-James W-A-James left review comments

Assignees

@W-A-James W-A-James

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@malikj2000 @baileympearson @W-A-James