Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-5424): test driver latest, client-encryption 6.0.0 in CI #3855

Merged
merged 1 commit into from
Aug 30, 2023
Merged

ci(NODE-5424): test driver latest, client-encryption 6.0.0 in CI #3855

merged 1 commit into from
Aug 30, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 30, 2023 •
edited by nbbeeken

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

  • The latest driver must remain compatible with v6.0.0 of mongodb-client-encryption the task reintroduced here specifically pins to that version and runs our test suite.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson
Copy link
Contributor Author

evergreen refresh

@baileympearson baileympearson marked this pull request as ready for review August 30, 2023 15:59
@nbbeeken nbbeeken self-assigned this Aug 30, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 30, 2023
@nbbeeken nbbeeken merged commit 3c4feae into main Aug 30, 2023
22 of 26 checks passed
@nbbeeken nbbeeken deleted the NODE-5424-add-back-testing-requirement branch August 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
2 participants
@baileympearson @nbbeeken