perf(NODE-5854): Conditional logger instantiation and precompute willLog perf fix #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
alenakhineika
added
the
Primary Review
|
Could you double-check the list in the PR description? To make sure that all requirements are met. |
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the title
alenakhineika
previously approved these changes
Feb 6, 2024
alenakhineika
added
Team Review
durran
requested changes
Feb 7, 2024
durran
requested changes
Feb 8, 2024
Co-authored-by: Durran Jordan <durran@gmail.com>
durran
approved these changes
Feb 9, 2024
nbbeeken
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc perf improvements to logger.
What is changing?
new MongoLoggeris only instantiated on the MongoClient when at least one of the component severities is turned on.willLogis now a precomputed nested object rather than a function call (access is cheaper than a function)Is there new documentation needed for these changes?
Not until logging is released NODE-5672
What is the motivation for this change?
To align with the company wide perf initiative and ensure that the logger is optimized.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript