Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-5829): update driver dependencies #3994

Merged
merged 13 commits into from
Feb 26, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Feb 13, 2024

Description

Update dev, prod, and peer dependencies in the driver to latest safe and compatible versions + ones with minimal code changes.

What is changing?

Dependency Update

No Peer Dependency Updates until next major release

Dev Dependency Updates

 @aws-sdk/credential-providers  ^3.465.0  →   ^3.515.0
 @microsoft/api-extractor        ^7.38.4  →    ^7.40.6
 @octokit/core                    ^4.2.4  →     ^5.1.0
 @types/node                    ^20.10.3  →  ^20.11.20
 @types/semver                    ^7.5.6  →     ^7.5.7
 @types/whatwg-url               ^11.0.3  →    ^11.0.4
 eslint                          ^8.55.0  →    ^8.56.0
 eslint-plugin-import            ^2.29.0  →    ^2.29.1
 mocha                           ^10.2.0  →    ^10.3.0
 semver                           ^7.5.4  →     ^7.6.0
 socks                            ^2.7.1  →     ^2.8.1
 ts-node                         ^10.9.1  →    ^10.9.2
 tsd                             ^0.28.1  →    ^0.30.6
 chai                            ^4.3.10  →     ^4.4.1

Production Dependency Updates
n/a at this time

Note: sinon and @types/sinon will be updated after node v16 bug fix is done in NODE-5942

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

QOL

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review February 21, 2024 10:20
@baileympearson baileympearson self-assigned this Feb 21, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 21, 2024
@baileympearson
Copy link
Contributor

here's what I see locally:

Package                           Current   Wanted  Latest  Location                                       Depended by
@microsoft/api-extractor           7.38.5   7.40.5  7.40.5  node_modules/@microsoft/api-extractor          node-mongodb-native
@types/sinon                      10.0.20  10.0.20  17.0.3  node_modules/@types/sinon                      node-mongodb-native
@typescript-eslint/eslint-plugin   5.62.0   5.62.0   7.0.2  node_modules/@typescript-eslint/eslint-plugin  node-mongodb-native
@typescript-eslint/parser          5.62.0   5.62.0   7.0.2  node_modules/@typescript-eslint/parser         node-mongodb-native
chai                               4.3.10    4.4.1   5.1.0  node_modules/chai                              node-mongodb-native
chalk                               4.1.2    4.1.2   5.3.0  node_modules/chalk                             node-mongodb-native
eslint                             8.55.0   8.56.0  8.56.0  node_modules/eslint                            node-mongodb-native
eslint-config-prettier             8.10.0   8.10.0   9.1.0  node_modules/eslint-config-prettier            node-mongodb-native
eslint-plugin-import               2.29.0   2.29.1  2.29.1  node_modules/eslint-plugin-import              node-mongodb-native
eslint-plugin-prettier              4.2.1    4.2.1   5.1.3  node_modules/eslint-plugin-prettier            node-mongodb-native
eslint-plugin-simple-import-sort   10.0.0   10.0.0  12.0.0  node_modules/eslint-plugin-simple-import-sort  node-mongodb-native
eslint-plugin-unused-imports        2.0.0    2.0.0   3.1.0  node_modules/eslint-plugin-unused-imports      node-mongodb-native
gcp-metadata                        5.3.0    5.3.0   6.1.0  node_modules/gcp-metadata                      node-mongodb-native
kerberos                          MISSING    2.1.0   2.1.0  -                                              node-mongodb-native
prettier                            2.8.8    2.8.8   3.2.5  node_modules/prettier                          node-mongodb-native
sinon                              15.2.0   15.2.0  17.0.1  node_modules/sinon                             node-mongodb-native
ts-node                            10.9.1   10.9.2  10.9.2  node_modules/ts-node                           node-mongodb-native
tsd                                0.28.1   0.28.1  0.30.5  node_modules/tsd                               node-mongodb-native
typescript                          5.0.4    5.3.3   5.3.3  node_modules/typescript                        node-mongodb-native

ts-node, tsd, api-extractor can probably be upgraded (as per discussions on other PRs)

  1. what about all the eslint plugins?
  2. did you mean to update @aws-sdk/credential-providers? the PR description says no peer dependencies were updated

@aditi-khare-mongoDB
Copy link
Contributor Author

@baileympearson

I did mean to update the aws-sdk peer dependency, per this slack conversation (i've added a clarification in the PR description).

The eslint-prettier updates cause import errors on my end.

src/cmap/auth/scram.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@nbbeeken
Copy link
Contributor

@aditi-khare-mongoDB Let me know if anything is blocking the changes I requested

@aditi-khare-mongoDB
Copy link
Contributor Author

@baileympearson @nbbeeken

You're right no peer updates, the updated dependencies are the following (only dev dependencies, no prod easily upgradable atm), and I've deleted my duplicate follow-up ticket since Neal's filed NODE-5693 already.

@aws-sdk/credential-providers  ^3.465.0  →   ^3.515.0
@microsoft/api-extractor        ^7.38.4  →    ^7.40.6
@octokit/core                    ^4.2.4  →     ^5.1.0
@types/node                    ^20.10.3  →  ^20.11.20
@types/semver                    ^7.5.6  →     ^7.5.7
@types/whatwg-url               ^11.0.3  →    ^11.0.4
eslint                          ^8.55.0  →    ^8.56.0
eslint-plugin-import            ^2.29.0  →    ^2.29.1
mocha                           ^10.2.0  →    ^10.3.0
semver                           ^7.5.4  →     ^7.6.0
socks                            ^2.7.1  →     ^2.8.1
ts-node                         ^10.9.1  →    ^10.9.2
tsd                             ^0.28.1  →    ^0.30.6

src/cmap/auth/scram.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@nbbeeken nbbeeken changed the title chore(NODE-5829): update driver dependencies for 6.4.0 chore(NODE-5829): update driver dependencies Feb 23, 2024
@baileympearson baileympearson merged commit eb5e2ab into main Feb 26, 2024
18 of 27 checks passed
@baileympearson baileympearson deleted the NODE-5829/update-driver-dependencies branch February 26, 2024 18:33
aditi-khare-mongoDB added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
3 participants