Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-5933): remove find-and-modify warning about defaults #3995

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

I3uckwheat
Copy link
Contributor

@I3uckwheat I3uckwheat commented Feb 14, 2024

Description

What is changing?

The previous version of the documentation (5.x) also had the lines that are removed in this commit. However, after testing and verifying, the default behavior is as-if the property "includeResultMetadata" was set to false.

Is there new documentation needed for these changes?

The change is documentation

What is the motivation for this change?

Incorrect documentation

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

The previous version of the documentation (5.x) also had the lines
that are removed in this commit. However, after testing and verifying,
the default behavior is as-if the property "includeResultMetadata" was
set to false.
@durran durran self-assigned this Feb 19, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 19, 2024
src/operations/find_and_modify.ts Outdated Show resolved Hide resolved
src/operations/find_and_modify.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika added the External Submission PR submitted from outside the team label Feb 19, 2024
@alenakhineika alenakhineika changed the title docs: remove find-and-modify warning about defaults docs(NODE-5933): remove find-and-modify warning about defaults Feb 19, 2024
@alenakhineika alenakhineika added the tracked-in-jira Ticket filed in MongoDB's Jira system label Feb 19, 2024
@durran durran merged commit 90cb6fa into mongodb:main Feb 19, 2024
25 of 27 checks passed
@I3uckwheat
Copy link
Contributor Author

Oh shoot, got confused. Thank you for fixing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
3 participants