Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-5938): sync retryable writes spec tests #3996

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Feb 14, 2024

Description

NODE-5797/DRIVERS-2799

What is changing?

  • Synced the following tests to latest compatible with DRIVERS-2799; the resulting files include changes from DRIVERS-2609, DRIVERS-2799, and DRIVERS-2802:
    • retryable-writes/unified/insertOne-serverErrors
    • retryable-writes/unified/bulkWrite-serverErrors
      • latest spec
    • unified-test-format/valid-pass/poc-retryable-writes
      • latest spec
    • Note: The NODE tickets corresponding to DRIVERS-2609 and DRIVERS-2802 were updated to reflect that the above tests have already been updated.
  • Cleaned up skipReason logic to provide a more accurate message when skipping tests:
    • Topology now takes precedence over server version (i.e., if neither the topology nor the server requirements are met, the skip will be attributed to the topology mismatch instead of the server version mismatch)
    • An aggregate skipReason is now displayed when none of multiple sets of requirements are met instead of only displaying the first unmet requirement
      • Example: requires mongodb version greater than 4.0.0 OR requires sharded but discovered a replicaset topology
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [N/A] Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review February 15, 2024 17:56
@nbbeeken nbbeeken self-assigned this Feb 15, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 15, 2024
}
skipTarget.skipReason = skipReasons.join(' OR ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbbeeken nbbeeken merged commit 10a5c5a into main Feb 15, 2024
27 checks passed
@nbbeeken nbbeeken deleted the NODE-5797/runon-reqs-in-retryable-writes-spec-tests branch February 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
2 participants