refactor(NODE-5953): move promisifying of randomBytes to utils #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested changes
Feb 22, 2024
nbbeeken
approved these changes
Feb 22, 2024
addaleax
approved these changes
Feb 22, 2024
nbbeeken
added
the
Primary Review
nbbeeken
deleted the
NODE-5953-move-promisifying-randomBytes-to-utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move promisifying of
randomBytesto utils.ts to make it module-scoped function and to reuse everywhere else.Is there new documentation needed for these changes?
None
What is the motivation for this change?
Technical debt leftover from NODE-5616
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript