Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-3353: Change OpenAPI metadata source to be spec string #428

Merged
merged 1 commit into from
Nov 2, 2022
Merged

DOP-3353: Change OpenAPI metadata source to be spec string #428

merged 1 commit into from
Nov 2, 2022

Conversation

rayangler
Copy link
Collaborator

Ticket

DOP-3353

Notes

  • It's more convenient to have the spec file's actual content as a string within the metadata. Since the parser layer already handles grabbing the content and turning it into a string, all the postprocessor has to do is grab it. This also avoids having to re-read the spec files across more than one of our tools (limiting it to the parser).

@rayangler rayangler marked this pull request as ready for review November 2, 2022 14:40
@rayangler rayangler requested a review from i80and November 2, 2022 14:40
i80and
i80and approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fewer type assertions make me MIGHTILY pleased!

@rayangler rayangler merged commit 5fdbdd3 into master Nov 2, 2022
@rayangler rayangler deleted the DOP-3353 branch November 2, 2022 14:46
rayangler added a commit that referenced this pull request Dec 14, 2022
@rayangler
Revert "DOP-3353: Change OpenAPI metadata source to be spec string (#428
0252e22 
)"

This reverts commit 5fdbdd3.
@rayangler rayangler mentioned this pull request Dec 15, 2022
Merged
5 tasks
rayangler added a commit that referenced this pull request Jan 4, 2023
@rayangler
Revert "DOP-3353: Change OpenAPI metadata source to be spec string (#428
6d69b28 
)" (#436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i80and i80and i80and approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rayangler @i80and