Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-3438: Remove devhub data paths #437

Merged
merged 2 commits into from
Jan 13, 2023
Merged

DOP-3438: Remove devhub data paths #437

merged 2 commits into from
Jan 13, 2023

Conversation

i80and
Copy link
Collaborator

@i80and i80and commented Jan 5, 2023 •
edited
Loading

In concept, we can ALSO toss out all of the pymongo logic and dependencies as well, but that can be a different task.

@i80and i80and marked this pull request as ready for review January 10, 2023 22:12
@i80and i80and requested a review from rayangler January 10, 2023 22:12
rayangler
rayangler reviewed Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current deletions seem like they should be okay. Just a question about deleting related test data (see comment).

Also, will we be removing devhub-specific directives from the rstspec, or is that better done separately?

snooty/test_devhub.py Show resolved Hide resolved
@i80and
Copy link
Collaborator Author

i80and commented Jan 12, 2023

@rayangler I've made this more comprehensive! Thanks for catching what I missed!

@i80and i80and requested a review from rayangler January 12, 2023 16:14
rayangler
rayangler approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! 🚀

@i80and i80and merged commit 2693a4d into mongodb:master Jan 13, 2023
@i80and i80and deleted the DOP-3438 branch January 13, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayangler rayangler rayangler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@i80and @rayangler