-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-3503: Add OpenAPI Versioning support to parser #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeigs
commented
Feb 14, 2023
mmeigs
commented
Feb 14, 2023
mmeigs
commented
Feb 14, 2023
rayangler
reviewed
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata looks good! Just a few comments for now
rayangler
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
i80and
reviewed
Feb 15, 2023
i80and
approved these changes
Feb 16, 2023
mmeigs
added a commit
that referenced
this pull request
Mar 27, 2023
* accessed version data, fetch apix data, added complete data to openapi_pages * created diagnostic InvalidVersion, implemented in postprocess * added two tests for openapi versioning * remove hardcoded test data * reorganized openapi postprocess, added InvalidOpenApiResponse diagnostic error * clean * PR feedback * Further PR feedback * PR feedback: flutter type check, deletion of other checks * fixed Sequence error, added todo Add openapi option api-version to rstspec.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-3503
Notes
Adds support for OpenAPI versions. Version data should be validated and passed as build metadata.
New openapi directive options called
versions
andapi-version
are implemented to allow the parser to source version data from APIx endpoints.In-depth information on these changes and parameters here.
Three thoughts and questions are provided below!