Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the MongoBackend #451

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Remove the MongoBackend #451

merged 3 commits into from
Mar 23, 2023

Conversation

i80and
Copy link
Collaborator

@i80and i80and commented Feb 15, 2023

No description provided.

@i80and i80and added enhancement New feature or request do not merge labels Feb 15, 2023
rayangler
rayangler reviewed Feb 16, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
snooty/main.py Show resolved Hide resolved
@i80and i80and marked this pull request as ready for review March 22, 2023 15:15
@i80and i80and requested a review from rayangler March 22, 2023 15:16
rayangler
rayangler reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things look good overall, but wanted to flag one error I experienced locally

snooty/main.py Show resolved Hide resolved
@i80and i80and requested a review from rayangler March 22, 2023 21:27
rayangler
rayangler approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Goodbye to the MongoBackend. It has served us well 😔

@i80and i80and merged commit 6ae0755 into mongodb:master Mar 23, 2023
@i80and i80and deleted the remove-atlas-backend branch March 23, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayangler rayangler rayangler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@i80and @rayangler