DOCSP-6332: Add misc. charts directives #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
requested review from
i80and and
rayangler
and removed request for
danielborowski
rayangler
reviewed
Aug 2, 2019
| const { className } = this.props; | ||
|
|
||
| /* | ||
| * Using findDOMNode() is discouraged in favor of passing refs to children, but we use it here |
There was a problem hiding this comment.
I thought you're able to use ref hooks for stateless components. Or am I thinking of something else? Just wondering
There was a problem hiding this comment.
We could use a ref hook to attach a ref to a DOM element within a functional component, but we can't attach a ref to the component itself (source). Good question!
rayangler
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JIRA] [Staging] Regression tested on guides and charts.
seealsoandexampleadmonitionshlist) component