Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4653: add permalink colors for dark vs light mode #1125

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

seungpark
Copy link
Collaborator

Stories/Links:

DOP-4653

Current Behavior:

current Permalinks on prod
permalinks in dark mode before changes

Staging Links:

Updated Permalink sample in cloud docs

Notes:

  • Got the OK from Design team via Liz to use the icon vs the svg

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link
Collaborator

@mayaraman19 mayaraman19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great! left a comment below

tests/unit/Heading.test.js Show resolved Hide resolved
src/components/Permalink.js Outdated Show resolved Hide resolved
@seungpark seungpark merged commit 48510e8 into main Jun 11, 2024
2 checks passed
@seungpark seungpark deleted the DOP-4653 branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants