Lighthouse Fix: Access correct commit message for both merges and PRs #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeigs
changed the title
caesarbell
reviewed
Jun 20, 2024
| response=$(curl --request GET --url 'https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/commits?page=1&per_page=1000' --header 'Accept: application/vnd.github.v3+json' --header 'Content-Type: application/json') | ||
| last_commit_message=$(echo "$response" | jq '.[-1].commit.message') | ||
| echo "::set-output name=last_commit_message::$last_commit_message" | ||
| if ${{ github.ref != 'refs/heads/main' }} == true; then |
There was a problem hiding this comment.
@mmeigs thanks for working on this. I would love a small walkthrough if you don't mind. I am not fully understanding what I am looking at 😆.
There was a problem hiding this comment.
Sure!! It took... an embarrassingly long amount of time for me.
seungpark
reviewed
Jun 20, 2024
seungpark
approved these changes
Jun 20, 2024
caesarbell
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
LGTM - Thank you @mmeigs for the demo. This seems like it is going to be a pretty cool addition to our workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
After recent merge, I realized that accessing the commit message is very different for PRs vs merges to main.
This deals with the differences and ensures that our lighthouse data will have complete and understandable commit messages.
Feel free to contact me with any questions! This took a long time to figure out. I have a public repo in my name that I have been using to experiment. I can show you action runs, if you'd like.
README updates