DOP-4757 #1159
Merged
DOP-4757 #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4757
Current Behavior:
The Language Selector popover floats away when scrolling (see ticket) if an option has not been selected. This is because
portalContainer.currentis undefined when rendering the Language Selector, for some reason. This PR removes "portaling" behavior for the Language Selector so that it doesn't float away anymore. Ideally, we would do away with usingportalContainer.currentduring render since this is discouraged in React, but doing so caused a lot of Z-index and CSS issues so I figured this was the easiest solution...See dropdown here in production
Staging Links:
Staging link (dark mode disabled)
Check out the selector in the sidenav (near the bottom) as well to ensure behavior is unchanged.
Notes:
README updates