DOP-1334: Implement MongoWebShell component #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
reviewed
Oct 22, 2020
src/components/MongoWebShell.js
Outdated
| }) => { | ||
| return ( | ||
| <iframe | ||
| className="mws-root" |
There was a problem hiding this comment.
Here's a nice opportunity to reduce our dependency on legacy CSS: instead of including the class that applies this rule, we can use Emotion's CSS Prop to apply the border styling. There are lots of examples of it in use in our codebase, or feel free to reach out for clarification!
src/components/MongoWebShell.js
Outdated
| sandbox="allow-scripts allow-same-origin" | ||
| width="100%" | ||
| height="320" | ||
| src={version ? SOURCE_URL + `?version=${version}` : SOURCE_URL} |
There was a problem hiding this comment.
[nit] No need to mix string concatenation with a template literal:
Suggested change
| src={version ? SOURCE_URL + `?version=${version}` : SOURCE_URL} | |
| src={version ? `${SOURCE_URL}?version=${version}` : SOURCE_URL} |
src/components/MongoWebShell.js
Outdated
| width="100%" | ||
| height="320" | ||
| src={version ? SOURCE_URL + `?version=${version}` : SOURCE_URL} | ||
| ></iframe> |
There was a problem hiding this comment.
[nit] We can probably make this iframe self closing:
Suggested change
| ></iframe> | |
| /> |
|
Bonus: Page that was having issues building renders now |
graysonhicks
pushed a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JIRA Ticket]
[Server Staging Link: /tutorial/update-documents-with-aggregation-pipeline]
[Server Staging Link: /tutorial/getting-started]
This PR allows the MongoDB Web Shell to be rendered on server docs.
Staging link was built with a locally changed version of
docs, usinginstead of the
.. raw::directive. Additionally, instances of.. only:: websitewere changed to.. cond:: htmlfor the staging link page.