(DOP-1921): Fix - Feedback widget tooltips should appear above the floating card #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
force-pushed
the
feedback-widget
branch
from
90ab995
to
94c1674
Compare
nlarew
changed the title
sophstad
reviewed
Jan 26, 2021
| @@ -9,6 +9,15 @@ import loadable from '@loadable/component'; | |||
| import { StarIcon } from '../icons'; | |||
| const Tooltip = loadable(() => import('./LeafygreenTooltip')); | |||
|
|
|||
| // Given a string, convert all regular space characters to non-breaking spaces | |||
| function convertSpacesToNbsp(someString) { | |||
There was a problem hiding this comment.
Any reason not to use replace() here? Something like someString.replace(/\s/g, ' ') may be cleaner/faster.
There was a problem hiding this comment.
Only reason is that I didn't think of it! Good suggestion, I'll update now.
sophstad
approved these changes
Jan 26, 2021
graysonhicks
pushed a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DOP-1921
usePortalprop!)nbsp;to keep everything on a single line. (Aesthetic!)