Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-5911: Refactor listTable and Paragraph components #84

Merged
merged 5 commits into from
Jun 25, 2019
Merged

Conversation

sophstad
Copy link
Member

[JIRA] [Staging]

  • Add Text component
    • Restructure Paragraph component so that it passes its children to the component factory
  • Pass ListItem children to component factory
  • Conditionally display text in <p> tag
    • Don't use <p> tags in tables (unless there are multiple paragraphs)
  • Improve tests so that list table outputs raw HTML

Copy link

@skerschb skerschb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We might want to put some comments around the list table paragraph conditional .

@sophstad sophstad merged commit 21bab0f into master Jun 25, 2019
@sophstad sophstad deleted the DOCSP-5911 branch June 25, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants