DOP-4193: removed unused footer component #972
Conversation
anabellabuckvar
changed the title
anabellabuckvar
changed the title
tests/unit/FeedbackWidget.test.js
Outdated
| //hideHeader={hideHeader} | ||
| > | ||
| <FeedbackForm /> | ||
| <div> | ||
| <FeedbackTab /> | ||
| <Heading nodeData={headingData} sectionDepth={1} /> | ||
| <FeedbackFooter /> | ||
| {/* <FeedbackFooter /> */} |
There was a problem hiding this comment.
Is there a reason to keep these two lines commented?
There was a problem hiding this comment.
the second one has been removed, see below for my reason behind keeping the above line commented
tests/unit/FeedbackWidget.test.js
Outdated
| @@ -41,13 +36,12 @@ async function mountFormWithFeedbackState(feedbackState = {}, options = {}) { | |||
| url: 'https://docs.mongodb.com/test', | |||
| docs_property: 'test', | |||
| }} | |||
| hideHeader={hideHeader} | |||
| //hideHeader={hideHeader} | |||
There was a problem hiding this comment.
(Nit) Looks like this comment is also a leftover
There was a problem hiding this comment.
I left it in intentionally, as someone will probably want to add tests that the hideHeader parameter works at some point. I can remove it if you think it's unecessary?
There was a problem hiding this comment.
Hm, I don't see any instances in which hideHeader is actually used, and I don't think that prop currently does anything... I'm okay with keeping it for now if we want, and I can handle double-checking as part of 5-star feedback work
Stories/Links:
DOP-4193
Current Behavior:
Master Staging link
Staging Links:
Staging link
Notes:
No functionality or UI components should be changed, this PR only deletes unused code.
Some of the tests in
FeedbackWidget.test.jswere flawed or improperly described, so those were cleaned up, too.