DOP-4208: lazy load OpenAPI component #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
commented
Dec 15, 2023
| import React, { lazy } from 'react'; | ||
|
|
||
| const ComponentMap = { | ||
| openapi: lazy(() => import('./OpenAPI')), |
There was a problem hiding this comment.
I included a few other components that should obviously be lazy loaded
If any objections, could revert this change to track the changes in separate ticket
There was a problem hiding this comment.
I think this is a good set of components to lazy load together
seungpark
commented
Dec 15, 2023
|
|
||
| const ComponentMap = { | ||
| openapi: lazy(() => import('./OpenAPI')), | ||
| video: lazy(() => import('./Video')), |
There was a problem hiding this comment.
example of video being lazy loaded on this page:
seungpark
commented
Dec 15, 2023
| const ComponentMap = { | ||
| openapi: lazy(() => import('./OpenAPI')), | ||
| video: lazy(() => import('./Video')), | ||
| instruqt: lazy(() => import('./Instruqt')), |
There was a problem hiding this comment.
instruqt seems to be getting redirected to a login page for both staging on master and test branches:
https://docs-mongodbcom-staging.corp.mongodb.com/master/docs/seung.park/master/tutorial/getting-started/
rayangler
approved these changes
Dec 18, 2023
| import React, { lazy } from 'react'; | ||
|
|
||
| const ComponentMap = { | ||
| openapi: lazy(() => import('./OpenAPI')), |
There was a problem hiding this comment.
I think this is a good set of components to lazy load together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4208
This PR is focused on reducing app bundle size by lazy loading OpenAPI component (which uses redoc as a dependency), as it is used as a single page component (for testing https://mongodb.com/docs/openapi/preview )
Current Behavior:
staged a couple on the same CDN to compare master branch vs test branch:
docs landing
open api preview page on docs landing
cloud docs
docs
Staging Links:
docs landing
openAPI preview page on docs landing
cloud docs
docs
Notes:
vs app bundle size on master
as well as bundle
b19b3968-67eaf58023f606c6395f.jsnot being present in test branch (for redoc package)