DRIVERS-2713: Run legacy transaction tests on LB topologies (#1459)

d2de776 previously added "load-balanced" to other legacy test formats but omitted the transactions spec.

This change ensures legacy transaction tests can be run on LB topologies, including Atlas Serverless (where "serverless: forbid" is not specified).

Some tests in retryable-commit.yml are incompatible with serverless and have been split off into a separate file with "serverless: forbid".

source/transactions/tests/README.rst

@@ -109,8 +109,8 @@ Each YAML file has the following keys:
 
   - ``topology`` (optional): An array of server topologies against which the
     tests can be run successfully. Valid topologies are "single", "replicaset",
-    and "sharded". If this field is omitted, the default is all topologies (i.e.
-    ``["single", "replicaset", "sharded"]``).
+    "sharded", and "load-balanced". If this field is omitted, the default is all
+    topologies (i.e. ``["single", "replicaset", "sharded", "load-balanced"]``).
 
   - ``serverless``: (optional): Whether or not the test should be run on Atlas
     Serverless instances. Valid values are "require", "forbid", and "allow". If
@@ -629,6 +629,7 @@ is the only command allowed in a sharded transaction that uses the
 Changelog
 =========
 
+:2023-09-28: Add ``load-balanced`` to test topology requirements.
 :2022-04-22: Clarifications to ``serverless`` and ``useMultipleMongoses``.
 :2019-05-15: Add operation level ``error`` field to assert any error.
 :2019-03-25: Add workaround for StaleDbVersion on distinct.

source/transactions/tests/legacy/abort.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/abort.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/bulk.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/bulk.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/causal-consistency.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/causal-consistency.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/commit.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/commit.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/count.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/count.yml

@@ -5,7 +5,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/create-collection.json

@@ -4,7 +4,8 @@
       "minServerVersion": "4.3.4",
       "topology": [
         "replicaset",
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/create-collection.yml

@@ -1,7 +1,7 @@
 runOn:
   -
     minServerVersion: "4.3.4"
-    topology: ["replicaset", "sharded"]
+    topology: ["replicaset", "sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/create-index.json

@@ -4,7 +4,8 @@
       "minServerVersion": "4.3.4",
       "topology": [
         "replicaset",
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/create-index.yml

@@ -1,7 +1,7 @@
 runOn:
   -
     minServerVersion: "4.3.4"
-    topology: ["replicaset", "sharded"]
+    topology: ["replicaset", "sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/delete.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/delete.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/error-labels-blockConnection.json

@@ -4,7 +4,8 @@
       "minServerVersion": "4.2",
       "topology": [
         "replicaset",
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/error-labels-blockConnection.yml

@@ -8,7 +8,7 @@
 runOn:
     -
         minServerVersion: "4.2"
-        topology: ["replicaset", "sharded"]
+        topology: ["replicaset", "sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/error-labels.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ],
       "serverless": "forbid"
     }

source/transactions/tests/legacy/error-labels.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
         # serverless proxy doesn't append error labels to errors in transactions
         # caused by failpoints (CLOUDP-88216)
         serverless: "forbid"

source/transactions/tests/legacy/errors-client.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/errors-client.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/errors.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/errors.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/findOneAndDelete.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/findOneAndDelete.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/findOneAndReplace.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/findOneAndReplace.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/findOneAndUpdate.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/findOneAndUpdate.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/insert.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/insert.yml

@@ -4,7 +4,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/isolation.json

@@ -9,7 +9,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ]
     }
   ],

source/transactions/tests/legacy/isolation.yml

@@ -6,7 +6,7 @@ runOn:
         topology: ["replicaset"]
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

source/transactions/tests/legacy/mongos-pin-auto-tests.py

@@ -16,7 +16,7 @@
 runOn:
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
         # serverless proxy doesn't append error labels to errors in transactions
         # caused by failpoints (CLOUDP-88216)
         serverless: "forbid"

source/transactions/tests/legacy/mongos-pin-auto.json

@@ -3,7 +3,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ],
       "serverless": "forbid"
     }

source/transactions/tests/legacy/mongos-pin-auto.yml

@@ -3,7 +3,7 @@
 runOn:
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
         # serverless proxy doesn't append error labels to errors in transactions
         # caused by failpoints (CLOUDP-88216)
         serverless: "forbid"

source/transactions/tests/legacy/mongos-recovery-token.json

@@ -3,7 +3,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ],
       "serverless": "forbid"
     }

source/transactions/tests/legacy/mongos-recovery-token.yml

@@ -1,7 +1,7 @@
 runOn:
     -
         minServerVersion: "4.1.8"
-        topology: ["sharded"]
+        topology: ["sharded", "load-balanced"]
         # serverless proxy doesn't use recovery tokens
         serverless: "forbid"
 

source/transactions/tests/legacy/pin-mongos.json

@@ -3,7 +3,8 @@
     {
       "minServerVersion": "4.1.8",
       "topology": [
-        "sharded"
+        "sharded",
+        "load-balanced"
       ],
       "serverless": "forbid"
     }