DRIVERS-1851 Skip crud-v1 tests for $out and collation on Serverless #1041
Conversation
| and placed under ``unified/``. Until such time that all original tests have been ported | ||
| to the unified test format, tests in each format will be grouped in their own subdirectory: | ||
|
|
||
| - ``v1/``: Legacy-v1 format tests | ||
| - ``unified/``: Tests using the `unified test format <../../../../unified-test-format/unified-test-format.rst>`_ | ||
| - ``unified/``: Tests using the `unified test format <../../unified-test-format/unified-test-format.rst>`_ |
There was a problem hiding this comment.
Ah thanks for fixing these.
There was a problem hiding this comment.
Looks good, but before approving I will need to check with serverless team whether bulkWrite operation succeeding on serverless when request has a collation is an intended behavior. If it is, changes in bulkWrite and adjacent tests should be reverted. If it's a server bug, then no further changes required.
| @@ -22,6 +22,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
I missed this test because it passed in C# driver.
The bulkWrite operation didn't fail despite having a collation present. The difference with other operations is that they had collation specified as operation option while bulkWrite has this option set for the individual requests.
Which means that it is either an intended behavior or a bug in serverless implementation.
There was a problem hiding this comment.
To add another data point, these tests were failing in Node.
| @@ -14,6 +14,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
This test didn't fail in C# driver either, because the deleteMany is executed as bulkWrite operation with a single deleteMany request.
| @@ -14,6 +14,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
Same as for deleteMany
| @@ -10,6 +10,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
Same behavior with the operation being an individual request of bulkWrite operation.
| @@ -14,6 +14,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
Same behavior with the operation being an individual request of bulkWrite operation.
| @@ -10,6 +10,7 @@ | |||
| } | |||
| ], | |||
| "minServerVersion": "3.4", | |||
| "serverless": "forbid", | |||
There was a problem hiding this comment.
Same behavior with the operation being an individual request of bulkWrite operation.
DRIVERS-1851
Atlas Serverless doesn't currently support
$outaggregations or collation, so the associated crud-v1 tests need to be skipped. This involved slightly amending the crud-v1 format.