DRIVERS-2224 Fix load-balanced DNS seedlist discovery tests for new dedicated lb port. #1148
Conversation
matthewdale
force-pushed
the
drivers1983-fix-dns-seed-lb-test
branch
from
c695fb9
to
fbd6890
Compare
|
@matthewdale: I realized I recently touched these tests in #1069 for DRIVERS-1519, but we don't actually run these tests in PHP so I was working blind there. @benjirewis: Do you have bandwidth to review this in my place? |
There was a problem hiding this comment.
I think this LGTM. Let me know if my understanding in the comment below is correct.
Let's not merge these changes until BUILD-14668 is done, and you're able to verify that these tests now pass in the Go driver (i.e. GODRIVER-2312 is done).
| the tests. The missing ``test.`` sub-domain in the SRV record target for | ||
| ``test12`` is deliberate. ``test22`` is used to test a custom service name | ||
| (``customname``). | ||
| Notes: |
There was a problem hiding this comment.
Thanks for cleaning up.
| _mongodb._tcp.test21.test.build.10gen.cc. 86400 IN SRV 27017 localhost.test.build.10gen.cc. | ||
| _customname._tcp.test22.test.build.10gen.cc 86400 IN SRV 27017 localhost.test.build.10gen.cc | ||
| _customname._tcp.test22.test.build.10gen.cc 86400 IN SRV 27017 localhost.test.build.10gen.cc. | ||
| _mongodb._tcp.test23.test.build.10gen.cc. 86400 IN SRV 8000 localhost.test.build.10gen.cc. |
There was a problem hiding this comment.
Just want to clarify my understanding. From offline conversation, it sounds like load balancer tests make use of the test1, test3, test4 and test20 records. The test1 and test4 records seem to be used to test that drivers fail during validation, so updating the port from 27017 (the mongos) to 8000 (the actual LB) is not necessary. The test3 record is used to test a successful connection, so the port should be updated, but that record is also used in the load-balanced/srvMaxHosts-zero test which expects to find 27017. So, we need a new test23 record that is identical to test3 but points to port 8000. Let me know if that all sounds right.
There was a problem hiding this comment.
That's correct (the test3 record is currently used in various replica-set tests, but you're right that it's required to stay the same for other tests).
There was a problem hiding this comment.
Ok, update: This change is now strictly additive. There are two new records, test23 (replaces test3) and test24 (replaces test20).
matthewdale
force-pushed
the
drivers1983-fix-dns-seed-lb-test
branch
from
fbd6890
to
2661836
Compare
matthewdale
changed the title
matthewdale
force-pushed
the
drivers1983-fix-dns-seed-lb-test
branch
from
2661836
to
0b11a20
Compare
matthewdale
changed the title
…edicated lb port.
matthewdale
force-pushed
the
drivers1983-fix-dns-seed-lb-test
branch
from
0b11a20
to
475971e
Compare
matthewdale
changed the title
Currently the
mongo-orchestrationchanges made with DRIVERS-1983 break some initial DNS seedlist discovery load-balanced tests because the driver must now connect to the load balancer to work correctly when in load-balanced mode. See this comment for more details about the test failures.BUILD-14668 adds two new SRV records:
_mongodb._tcp.test23.test.build.10gen.cc. 86400 IN SRV 8000 localhost.test.build.10gen.cc._mongodb._tcp.test24.test.build.10gen.cc. 86400 IN SRV 8000 localhost.test.build.10gen.cc.and one new TXT record:
test24.test.build.10gen.cc. 86400 IN TXT "loadBalanced=true"This PR updates the
initial-dns-seedlist-discovery/load-balancerspec tests to use those new recods to work with the new/updated DNS SRV records and document the SRV record updates in the README.Note! This PR MUST NOT be merged until BUILD-14668 is complete.