DRIVERS-2287 Clarify interaction of bypassAutoEncryption and csfle search paths #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Thank you for the change, LGTM!
It seems like bypassAutoEncryption could be implemented by using a ClientEncryption instance rather than a separate libmongocrypt handle (on what at least the Python and Node.js bindings call AutoEncrypter), in which case the csfle library should probably never be loaded
That is a great point I had not considered. csfle, like mongocryptd, is not needed in the ClientEncryption instance.
comandeo
approved these changes
Apr 20, 2022
addaleax
deleted the
2287-clarify-bypassAutoEncryption-csfle-search-paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking the behavior of not setting csfle search paths when
bypassAutoEncryptionwas passed, because:bypassAutoEncryptioncould be implemented by using aClientEncryptioninstance rather than a separate libmongocrypt handle (on what at least the Python and Node.js bindings callAutoEncrypter), in which case the csfle library should probably never be loaded