Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2188 Skip comment error test on sharded #1192

Merged
merged 1 commit into from Apr 27, 2022
Merged

DRIVERS-2188 Skip comment error test on sharded #1192

merged 1 commit into from Apr 27, 2022

Conversation

comandeo
Copy link

No description provided.

jmikola
jmikola approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you like to wait for a POC driver to pass its test suite before merging?

@comandeo
Copy link
Author

Yes, I would love to. Tests are running in the corresponding Ruby PR - mongodb/mongo-ruby-driver#2451
I won't merge this one until all tests pass; we have configurations with affected versions/topologies.

ShaneHarvey
ShaneHarvey approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested here: https://spruce.mongodb.com/version/626830a5d6d80a2c637f2856

@comandeo comandeo marked this pull request as ready for review April 26, 2022 18:40
@comandeo comandeo requested a review from a team as a code owner April 26, 2022 18:40
@comandeo comandeo requested review from benjirewis and removed request for a team April 26, 2022 18:40
@comandeo comandeo merged commit 938a402 into mongodb:master Apr 27, 2022
@comandeo comandeo deleted the 2188-skip-sharded branch April 27, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@comandeo @jmikola @ShaneHarvey @benjirewis @comandeo-mongo