Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVER-2017 relax multi/upsert expectations #1251

Merged
merged 1 commit into from
Jun 15, 2022
Merged

DRIVER-2017 relax multi/upsert expectations #1251

merged 1 commit into from
Jun 15, 2022

Conversation

prestonvasquez
Copy link
Contributor

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@prestonvasquez prestonvasquez requested a review from a team as a code owner June 14, 2022 21:46
eramongodb
eramongodb approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. This was known and addressed during review, but managed to slip through during a followup review when adding commandStartedEvent assertions. Thank you for the fixes.

@prestonvasquez prestonvasquez merged commit fa046c7 into master Jun 15, 2022
@prestonvasquez prestonvasquez deleted the DRIVER-2017-multi-upsert-abstraction branch June 15, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prestonvasquez @kevinAlbs @eramongodb