Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC-337: Deprecate modifiers and clean up existing wording for default values #127

Merged
merged 5 commits into from Jan 9, 2017

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 9, 2017

Supersedes #102.

@@ -12,7 +12,7 @@ Driver CRUD API
:Status: Approved
:Type: Standards
:Minimum Server Version: 2.4
:Last Modified: Aug. 5, 2016
:Last Modified: Aug. 17, 2016
Copy link
Member Author

@jmikola jmikola Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craiggwilson: Shall I bump this to the current date?

Based on crud.rst's git history, it was last bumped with @estolfo's first commit for DRIVERS-291 (collation options).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm.

@craiggwilson
Copy link
Contributor

lgtm. After this is merged in, you'll need to open a DRIVERS ticket for this change detailing how a driver needs to support backwards compatibility with the old "modifiers" field.

@jmikola jmikola merged commit 8dfac0b into master Jan 9, 2017
@jmikola jmikola deleted the jmikola-spec337 branch January 9, 2017 22:13
jmikola added a commit that referenced this pull request Jan 9, 2017
Most recent changelog entries should have been bumped to the day that #127 was merged.

The changelog date for collation options being added to bulk write models should match 67f86a4. The collation option was never in BulkWriteOptions, so "removed it from bulk write" was deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants