Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2515: Add a positive prose test for CreateEncryptedCollection. #1357

Merged
merged 2 commits into from Dec 14, 2022
Merged

DRIVERS-2515: Add a positive prose test for CreateEncryptedCollection. #1357

merged 2 commits into from Dec 14, 2022

Conversation

DmitryLukyanov
Copy link

@DmitryLukyanov DmitryLukyanov commented Dec 14, 2022 •
edited

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@DmitryLukyanov DmitryLukyanov requested a review from a team as a code owner December 14, 2022 17:00
@DmitryLukyanov DmitryLukyanov requested review from comandeo and vector-of-bool and removed request for a team December 14, 2022 17:00
vector-of-bool
vector-of-bool approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one rST syntax comment.

source/client-side-encryption/tests/README.rst Outdated
2. Invoke `CreateEncryptedCollection(CE, DB, "testing1", Opts, "local", null)`
to obtain a new collection `Coll` and data key `key1`. Expect success.
3. Use `CE` to explicitly encrypt the string "123-45-6789" using
algorithm `Unindexed` and data key `key1`. Refer result as `encryptedPayload`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent this line by three spaces.

@DmitryLukyanov
Copy link
Author

Checked with c# impl

@DmitryLukyanov DmitryLukyanov merged commit 10122e7 into mongodb:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vector-of-bool vector-of-bool vector-of-bool approved these changes

@comandeo comandeo Awaiting requested review from comandeo comandeo is a code owner automatically assigned from mongodb/dbx-spec-owners-fle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DmitryLukyanov @vector-of-bool