Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2668 Add SRV test with uppercase hostname #1473

Merged
merged 1 commit into from Nov 21, 2023

Conversation

ShaneHarvey
Copy link
Member

DRIVERS-2668. Unfortunately, as noted in DEVPROD-174, it's not possible to add the exact test case I envisioned for DRIVERS-2668 (where DNS returns uppercase letters in the SRV result). However we can still add this related test case with uppercase letters in the initial SRV hostname.

Please complete the following before merging:

@dariakp
Copy link
Contributor

dariakp commented Nov 20, 2023

@ShaneHarvey I was out on PTO when this landed. It looks like the original ticket has not been updated based on the most recent information about what's possible to test - could you add the new context to the ticket summary so that the final outcome (what we will actually test and what sort of bug this is meant to catch) is more obvious to the teams that go to implement this? Also, is this more limited test still sufficient to prevent the kind of issue that python originally ran into?

@ShaneHarvey
Copy link
Member Author

I was planning to update the ticket description once this is merged.

Also, is this more limited test still sufficient to prevent the kind of issue that python originally ran into?

No. This test does not cover the bug in PYTHON-3800 but it's still useful because it ensures drivers normalize the hostname before SRV+TXT lookup.

@ShaneHarvey ShaneHarvey merged commit 82da02b into mongodb:master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants