DRIVERS-2802: Require 4.3.1+ when using failCommand errorLabels option #1489
Conversation
jmikola
requested review from
alcaeus and
isabelatkinson
and removed request for
a team
Synced with mongodb/specifications#1489 No changes were needed for retryable writes prose tests. libmongoc only implements prose test 3, which already requires MongoDB 6.0+. Note: with_transaction/callback-retry.json is unrelated but was missed in CDRIVER-2975.
Synced with mongodb/specifications#1489 No changes were needed for retryable writes prose tests. libmongoc only implements prose test 3, which already requires MongoDB 6.0+. Note: with_transaction/callback-retry.json is unrelated but was missed in CDRIVER-2975.
Synced with mongodb/specifications#1489 No changes were needed for retryable writes prose tests. libmongoc only implements prose test 3, which already requires MongoDB 6.0+. Note: with_transaction/callback-retry.json is unrelated but was missed in CDRIVER-2975. This test currently fails and has been skipped (see: CDRIVER-4811).
Synced with mongodb/specifications#1489 No changes were needed for retryable writes prose tests. libmongoc only implements prose test 3, which already requires MongoDB 6.0+. Note: with_transaction/callback-retry.json is unrelated but was missed in CDRIVER-2975. This test currently fails and has been skipped (see: CDRIVER-4811).
This also improves version info in the failCommand docs within the Unified Test Format spec.
| specification. This test requires MongoDB 4.2.9+ for ``blockConnection`` support in the failpoint. | ||
| specification. | ||
|
|
||
| This test requires MongoDB 4.3.4+ for both the ``errorLabels`` and |
There was a problem hiding this comment.
Why 4.3.4 here rather than 4.3.1? I suggest using the latter for consistency if the requirements are the same as the other tests changed in this PR
There was a problem hiding this comment.
Since no one should be testing with any 4.3 release, can we just bump to 4.4?
There was a problem hiding this comment.
Why 4.3.4 here rather than 4.3.1
4.3.4 is the first release where both errorLabels _and blockConnection were available (see: SERVER-41070).
Since no one should be testing with any 4.3 release, can we just bump to 4.4?
IMO, using exact versions when they're accessible is helpful to preserve history. Seeing the versions before I started on this PR is what clued me in that https://github.com/mongodb/mongo/wiki/The-%22failCommand%22-fail-point and the Unified Test Format spec needed to be updated.
I suppose something to consider down the line would be to periodically bump server versions in spec/prose tests after final versions are released (e.g. after 7.0 is cut, we should have no server version requirements for pre-7.0 unstable releases in existing tests) -- but I don't need to be involved in that.
FWIW, I also managed to get https://github.com/mongodb/mongo/wiki/The-%22failCommand%22-fail-point updated (thanks @Schubes). |
Synced with mongodb/specifications#1489 Updates retryable writes prose test 3 to relocate the errorLabels field when configuring a fail point. Note: with_transaction/callback-retry.json is unrelated but was missed in CDRIVER-2975. This test currently fails and has been skipped (see: CDRIVER-4811).
https://jira.mongodb.org/browse/DRIVERS-2802
This also improves version info in the failCommand docs within the Unified Test Format spec.
Please complete the following before merging:
POC: mongodb/mongo-c-driver#1508
libmongoc patch build: https://spruce.mongodb.com/version/659d96522fbabe331b61658a