Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC-1121 Test only initial commands include readConcern #364

Merged

Conversation

ShaneHarvey
Copy link
Member

Adds tests that readConcern is only added for the initial command in a transaction. None of the existing tests cover this case. Tests countDocuments, find, aggregate, distinct, and runCommand.

These changes are tested by the python driver.

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit 93707eb into mongodb:master Jul 27, 2018
@ShaneHarvey ShaneHarvey deleted the test-txn-readConcern-initial branch July 27, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants