SPEC-1136: Add insertedCount to BulkWriteResult #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I screwed up the JSON formatting when I added this file... LGTM. Should we also add insertedCount to all the other uses of bulkWrite? |
AFAIK, this is the only test for |
jmikola
force-pushed
the
bulk-insertedCount
branch
from
112e775
to
66b7faf
Compare
jmikola
force-pushed
the
bulk-insertedCount
branch
from
66b7faf
to
9ab0a18
Compare
jmikola
changed the title
|
Updated and tested against PHPLIB (with minor changes to our test harness). Please review when you get a chance (and feel free to test Python if you like). |
ShaneHarvey
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/SPEC-1136
insertedCountis a required BulkWriteResult field, so there's no reason we shouldn't include it in the expectation.