Fix StitchError stack traces in node #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures are from currently-broken |
UnicodeSnowman
force-pushed
the
fix-stitcherror-stacktraces-in-node
branch
3 times, most recently
from
98a85a9
to
ddafc16
Compare
edaniels
approved these changes
Nov 15, 2017
* Add `babel-plugin-transform-builtin-extend` * Subclassing builtin types needs special treatment by babel * Without this plugin, in a node environment, a subclass of Error does not actually behave like a true subclass, which manifests itself via a missing stacktrace when a StitchError is thrown More details [here](babel/babel#3083)
UnicodeSnowman
force-pushed
the
fix-stitcherror-stacktraces-in-node
branch
from
ddafc16
to
b1378f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-plugin-transform-builtin-extendMore details here
We've been seeing a handful of flaky tests in evergreen caused by uncaught promises. Because of the missing stacktraces, these errors are super hard to track down. This should help with that.
Before
After