Provide local accessor for bson_t.len
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
approved these changes
Apr 5, 2019
kmahar
approved these changes
Apr 5, 2019
.gitignore
Outdated
| @@ -65,3 +65,4 @@ fastlane/report.xml | |||
| fastlane/Preview.html | |||
| fastlane/screenshots | |||
| fastlane/test_output | |||
| .vscode | |||
In Swift 5, `bson_t` is treated as an `OpaquePointer` so we no longer have type information for its fields. This allows us to retrieve the `len` field by providing a custom accessor.
mbroadst
force-pushed
the
SWIFT-384/bson-len-accessor
branch
from
13f1ca5
to
53d9bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 5,
bson_tis treated as anOpaquePointerso we nolonger have type information for its fields. This allows us to
retrieve the
lenfield by providing a custom accessor.