chore: migrates alert_configuration to new SDK (#1630)

* migrate alert_configuration to new sdk

* fix lint

* fix missing lint

* refactor unknown check for notifierID and remove Matcher from old sdk from tests

* set to til groupId

* merge master to INTMDB-1121

* use SafeString util method instead of accessing directly string pointer variables

* avoid risk of accessing the pointer value

mongodbatlas/fw_data_source_mongodbatlas_alert_configuration.go

@@ -306,10 +306,10 @@ func newTFAlertConfigurationDSModel(apiRespConfig *admin.GroupAlertsConfig, proj
 		Created:               types.StringPointerValue(util.TimePtrToStringPtr(apiRespConfig.Created)),
 		Updated:               types.StringPointerValue(util.TimePtrToStringPtr(apiRespConfig.Updated)),
 		Enabled:               types.BoolPointerValue(apiRespConfig.Enabled),
-		MetricThresholdConfig: newTFMetricThresholdConfigModelV2(apiRespConfig.MetricThreshold, []tfMetricThresholdConfigModel{}),
-		ThresholdConfig:       newTFThresholdConfigModelV2(apiRespConfig.Threshold, []tfThresholdConfigModel{}),
-		Notification:          newTFNotificationModelListV2(apiRespConfig.Notifications, []tfNotificationModel{}),
-		Matcher:               newTFMatcherModelListV2(apiRespConfig.Matchers, []tfMatcherModel{}),
+		MetricThresholdConfig: newTFMetricThresholdConfigModel(apiRespConfig.MetricThreshold, []tfMetricThresholdConfigModel{}),
+		ThresholdConfig:       newTFThresholdConfigModel(apiRespConfig.Threshold, []tfThresholdConfigModel{}),
+		Notification:          newTFNotificationModelList(apiRespConfig.Notifications, []tfNotificationModel{}),
+		Matcher:               newTFMatcherModelList(apiRespConfig.Matchers, []tfMatcherModel{}),
 	}
 }
 

mongodbatlas/fw_data_source_mongodbatlas_alert_configuration_test.go

@@ -8,12 +8,12 @@ import (
 	"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/testutils"
-	matlas "go.mongodb.org/atlas/mongodbatlas"
+	"go.mongodb.org/atlas-sdk/v20231115001/admin"
 )
 
 func TestAccConfigDSAlertConfiguration_basic(t *testing.T) {
 	var (
-		alert          = &matlas.AlertConfiguration{}
+		alert          = &admin.GroupAlertsConfig{}
 		dataSourceName = "data.mongodbatlas_alert_configuration.test"
 		orgID          = os.Getenv("MONGODB_ATLAS_ORG_ID")
 		projectName    = acctest.RandomWithPrefix("test-acc")
@@ -42,7 +42,7 @@ func TestAccConfigDSAlertConfiguration_basic(t *testing.T) {
 
 func TestAccConfigDSAlertConfiguration_withThreshold(t *testing.T) {
 	var (
-		alert          = &matlas.AlertConfiguration{}
+		alert          = &admin.GroupAlertsConfig{}
 		dataSourceName = "data.mongodbatlas_alert_configuration.test"
 		orgID          = os.Getenv("MONGODB_ATLAS_ORG_ID")
 		projectName    = acctest.RandomWithPrefix("test-acc")
@@ -71,7 +71,7 @@ func TestAccConfigDSAlertConfiguration_withThreshold(t *testing.T) {
 
 func TestAccConfigDSAlertConfiguration_withOutput(t *testing.T) {
 	var (
-		alert          = &matlas.AlertConfiguration{}
+		alert          = &admin.GroupAlertsConfig{}
 		dataSourceName = "data.mongodbatlas_alert_configuration.test"
 		orgID          = os.Getenv("MONGODB_ATLAS_ORG_ID")
 		projectName    = acctest.RandomWithPrefix("test-acc")
@@ -104,7 +104,7 @@ func TestAccConfigDSAlertConfiguration_withOutput(t *testing.T) {
 
 func TestAccConfigDSAlertConfiguration_withPagerDuty(t *testing.T) {
 	var (
-		alert          = &matlas.AlertConfiguration{}
+		alert          = &admin.GroupAlertsConfig{}
 		dataSourceName = "data.mongodbatlas_alert_configuration.test"
 		orgID          = os.Getenv("MONGODB_ATLAS_ORG_ID")
 		projectName    = acctest.RandomWithPrefix("test-acc")