Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1254

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Update README.md #1254

merged 2 commits into from
Jun 21, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 19, 2023 •
edited

Description

Updated the Go version in the README.md

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 19, 2023 15:41
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 19, 2023 15:41
maastha
maastha approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit f0dd3bc into master Jun 21, 2023
14 checks passed
@andreaangiolillo andreaangiolillo deleted the andreaangiolillo-patch-1 branch June 21, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

@Zuhairahmed Zuhairahmed Awaiting requested review from Zuhairahmed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreaangiolillo @maastha