INTMDB-878: [Terraform] Improve acceptance test setup to run in parallel & against cloud-dev - Network #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,118 +0,0 @@ | |||
| package mongodbatlas | |||
There was a problem hiding this comment.
I have moved the data source tests into the resource tests. By doing this, there is no need to create a new serverless cluster specifically for these tests. Instead, we can efficiently reuse the clusters that are already created for the resource tests.
andreaangiolillo
requested review from
colm-quinn,
martinstibbe,
Zuhairahmed and
maastha
colm-quinn
reviewed
Jun 21, 2023
| ) | ||
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| resource.ParallelTest(t, resource.TestCase{ |
There was a problem hiding this comment.
I still can't get over how simple a change this is vs the impact it has. Great work!
colm-quinn
approved these changes
Jun 21, 2023
Zuhairahmed
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the network tests from the old workflow (~ 2 hours to run) to a new one running the tests concurrently and against cloud-dev (~ 15 minutes). The new workflow splits the network tests into two GitHub Jobs.
GitHub Action Now (5332697190)
GitHub Action Before (5245497202)
Type of change:
Required Checklist:
Further comments