Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-896: add MicrosoftTeamsWebhookURL to values that are based on schema vs API #1279

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

martinstibbe
Copy link
Contributor

@martinstibbe martinstibbe commented Jun 28, 2023

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.
Add MicrosoftTeamsWebhookURL to values that are based on schema vs API
Link to any related issue(s):
#1275

INTMDB-896: add MicrosoftTeamsWebhookURL to values that are based on schema vs API

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner June 28, 2023 19:35
@Zuhairahmed Zuhairahmed self-requested a review June 30, 2023 21:43
@@ -754,6 +754,7 @@ func flattenAlertConfigurationNotifications(d *schema.ResourceData, notification
notifications[i].WebhookSecret = notificationsSchema[i].WebhookSecret
notifications[i].SMSEnabled = notificationsSchema[i].SMSEnabled
notifications[i].EmailEnabled = notificationsSchema[i].EmailEnabled
notifications[i].MicrosoftTeamsWebhookURL = notificationsSchema[i].MicrosoftTeamsWebhookURL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is flattenAlertConfigurationNotifications used also in the data sources? I am wondering if we need to update the data source as well. 🤔

@martinstibbe martinstibbe merged commit c066ead into master Jul 3, 2023
18 checks passed
@martinstibbe martinstibbe deleted the INTMDB-896 branch July 3, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants