Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-904: HELP: mongodbatlas_org_invitation is missing ORG_BILLING_READ_ONLY role support #1287

Merged
merged 7 commits into from
Jul 3, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 3, 2023

Description

Ticket: INTMDB-904
Link to any related issue(s): #1280

This PR removes the hardcoded validation on the roles field. We will rely on the API from now on.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreaangiolillo LGTM with a few suggestions to use current doc links

website/docs/d/org_invitation.html.markdown Outdated Show resolved Hide resolved
website/docs/r/org_invitation.html.markdown Outdated Show resolved Hide resolved
website/docs/r/org_invitation.html.markdown Outdated Show resolved Hide resolved
andreaangiolillo and others added 5 commits July 3, 2023 17:47
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
@andreaangiolillo andreaangiolillo merged commit 9855446 into master Jul 3, 2023
18 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-904 branch July 3, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants