-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-939: [Terraform] Feature Add: Shared-Tier Snapshots #1323
Conversation
…ngodbatlas into INTMDB-939
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few doc comments, otherwise LGTM
website/docs/d/cloud_provider_shared_tier_snapshot.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_snapshot.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_snapshots.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_snapshots.html.markdown
Outdated
Show resolved
Hide resolved
Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
func dataSourceMongoDBAtlasSharedTierSnapshot() *schema.Resource { | ||
return &schema.Resource{ | ||
ReadContext: dataSourceMongoDBAtlasSharedTierSnapshotRead, | ||
Schema: map[string]*schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - We could easily generate initial schemas for developers to adapt them in the future.
We have that capability in the SDK - just need to adjust it to your needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share more details about it? A link to the SDK codebase where I can look at would be enough. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that comment.
We have a doc for using custom templates:
https://github.com/mongodb/atlas-sdk-go/blob/main/tools/CONTRIBUTING.md#generating-custom-files
We can generate some level of boilerplate for the team like TF schemas.
We can release it under separate module or package.
Description
Ticket: INTMDB-939
This PR adds support to
mongodbatlas_shared_tier_snapshot
andmongodbatlas_shared_tier_snapshots
Type of change:
Required Checklist:
Further comments
Tested Locally