-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-546: [Terraform] Feature Add: Shared-Tier Restore Job #1324
Conversation
mongodbatlas/data_source_mongodbatlas_cloud_shared_tier_restore_jobs.go
Outdated
Show resolved
Hide resolved
mongodbatlas/data_source_mongodbatlas_cloud_shared_tier_restore_jobs.go
Outdated
Show resolved
Hide resolved
Excellent PR! thank you so much. I left a couple of open-ended questions for your consideration. |
mongodbatlas/data_source_mongodbatlas_cloud_shared_tier_restore_jobs.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from SDK point of view. I haven't verified the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments on docs, feel free to merge after addressing. After that LGTM
website/docs/d/cloud_provider_shared_tier_restore_job.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_restore_jobs.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_restore_job.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/cloud_provider_shared_tier_restore_jobs.html.markdown
Outdated
Show resolved
Hide resolved
…kdown Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
…rkdown Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
…kdown Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
…rkdown Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
Description
Ticket: INTMDB-546
This PR adds support for
mongodbatlas_shared_tier_restore_job
andmongodbatlas_shared_tier_restore_jobs
Type of change:
Required Checklist:
Further comments