Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-436: Update privatelink endpoint service resources timeout config #1329

Merged
merged 2 commits into from
Jul 20, 2023
Merged

INTMDB-436: Update privatelink endpoint service resources timeout config #1329

merged 2 commits into from
Jul 20, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jul 18, 2023 •
edited
Loading

Description

Enable configurable timeout, and make consistent 2 hour defaulting timeout across dedicated, serverless, and privatelink_endpoint_service_data_federation_online_archive

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-436

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@maastha maastha requested a review from Zuhairahmed July 18, 2023 13:45
@maastha maastha marked this pull request as ready for review July 18, 2023 14:23
@maastha maastha requested a review from a team as a code owner July 18, 2023 14:23
andreaangiolillo
andreaangiolillo reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to release 1.10.2 before merging this PR

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_serverless.go Show resolved Hide resolved
...dbatlas/resource_mongodbatlas_privatelink_endpoint_service_data_federation_online_archive.go Show resolved Hide resolved
andreaangiolillo
andreaangiolillo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zuhairahmed
Zuhairahmed approved these changes Jul 20, 2023
View reviewed changes
mongodbatlas/resource_mongodbatlas_privatelink_endpoint_serverless.go
@@ -182,7 +183,7 @@ func resourceMongoDBAtlasPrivateLinkEndpointServerlessDelete(ctx context.Context
Refresh: resourcePrivateLinkEndpointServerlessRefreshFunc(ctx, conn, projectID, instanceName, endpointID),
Timeout: d.Timeout(schema.TimeoutDelete),
MinTimeout: 5 * time.Second,
Delay: 3 * time.Second,
Delay: 5 * time.Second,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why 5 seconds delay?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zuhairahmed just making it consistent across privatelink_endpoint resources.

@maastha maastha merged commit bf8e8c8 into master Jul 20, 2023
17 checks passed
@maastha maastha deleted the INTMDB-436 branch July 20, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maastha @andreaangiolillo @Zuhairahmed