Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-933: Make region atributed optional computed in third-party-integration #1332

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jul 19, 2023

Description

When configuring PAGER_DUTY integration, the user may/may not set region attribute. If user doesn't set it, the API returns a default value during READ, currently because of that every time the user runs terraform plan, the 'region' attribute is determined as modified.
This PR therefor marks the 'region' attributed as Optional and Computed.

Link to any related issue(s): INTMDB-933
#1316

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@maastha maastha changed the title INTMDB-933: Make region atributed optional computed in third-party-in… INTMDB-933: Make region atributed optional computed in third-party-integration Jul 20, 2023
@maastha maastha added the bug label Jul 20, 2023
@maastha maastha marked this pull request as ready for review July 20, 2023 08:29
@maastha maastha requested a review from a team as a code owner July 20, 2023 08:29
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha maastha merged commit 2cc94c9 into master Jul 20, 2023
29 checks passed
@maastha maastha deleted the INTMDB-933-TPI-pagerduty branch July 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants